stephsi commented on PR #69271: URL: https://github.com/apache/airflow/pull/69271#issuecomment-4916333943
Hello @bramhanandlingala! Thanks for creating a PR related to my issue. I think your suggested changes make sense overall. I have one suggestion though: Your three test cases now cover `config-only`, `connection-over-config` and `neither-set-default` , I would argue that you should also adjust the already existing test case `connection-only` to the style of your three created test cases, so it is more clear that these four test cases belong together. Also add a comment at the beginning to the already existing test case similar to your three test cases. I also have some wording suggestions for the test comments, but these are maybe more personal preferences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
