kacpermuda commented on code in PR #69477:
URL: https://github.com/apache/airflow/pull/69477#discussion_r3545977801


##########
providers/snowflake/src/airflow/providers/snowflake/operators/snowflake.py:
##########
@@ -284,7 +307,7 @@ def __init__(
         self.query_ids: list[str] = []
 
 
-class SnowflakeSqlApiOperator(SQLExecuteQueryOperator):
+class SnowflakeSqlApiOperator(ResumableJobMixin, SQLExecuteQueryOperator):

Review Comment:
   Not familiar with `ResumableJobMixin`, is there a difference in how the 
operator behaves in the happy path, when there is no worker crash etc? The 
OpenLineage listener is using self.query_ids and also self.get_db_hook (which 
calls cached self._hook here). Should we expect any differences in the happy 
path? (I understand that if worker crashes or something, we'll get a different 
hook instance)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to