amoghrajesh commented on code in PR #69530:
URL: https://github.com/apache/airflow/pull/69530#discussion_r3549295804


##########
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -157,7 +182,7 @@ def execute(self, context: Context) -> 
list[GetStatementResultResponseTypeDef] |
         if query_execution_output.session_id:
             context["ti"].xcom_push(key="session_id", 
value=query_execution_output.session_id)
 
-        if self.deferrable and self.wait_for_completion:
+        if self.wait_for_completion:

Review Comment:
   This code only runs when `deferrable=True`, `execute()` starts with `if not 
self.deferrable: return self.execute_resumable(context)`, so a user who doesn't 
want the triggerer / deferrable simply sets `deferrable=False` and never 
reaches this branch at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to