pierrejeambrun commented on code in PR #68171: URL: https://github.com/apache/airflow/pull/68171#discussion_r3552746948
########## airflow-core/src/airflow/ui/src/layouts/Details/Graph/utils/manualLayoutStore.ts: ########## @@ -0,0 +1,116 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { GraphNode } from "./manualLayout"; + +export type ManualLayoutViewport = { + readonly x: number; + readonly y: number; + readonly zoom: number; +}; + +export type ManualLayoutState = { + readonly isManualLayout: boolean; + readonly manualEdgeNodeIds: Set<string>; + readonly manualNodes: Array<GraphNode>; + readonly viewport?: ManualLayoutViewport; +}; + +const keySeparator = "\0"; +const manualLayoutStates = new Map<string, ManualLayoutState>(); +const pendingClearTimers = new Map<string, ReturnType<typeof setTimeout>>(); + +export const getManualLayoutKey = ({ dagId, runId = "" }: { dagId: string; runId?: string }) => Review Comment: The persistence accross tab navigation adds 5 useEffect / sync effect, `isRestoringManualLayoutKeyRef` and a setTimeout etc... just for this. Also it's probably not the best way to proceed if we want to implement that. We could add a custom external store and make it a single source of truth. I would remove all that for now, we can always follow up with improvements feature as needed, just so this PR is not blocked by those additional features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
