Miretpl commented on PR #68784:
URL: https://github.com/apache/airflow/pull/68784#issuecomment-4929045226
Question to the other maintainers @jedcunningham @hussein-awala @jscheffl
@bugraoz93 @potiuk (if anyone else has an opinion on it, feel free to add it!):
I checked all materials from our discussions regarding Helm Refurbish, and
we didn't discuss this part in detail, so I would like to know your opinion
before going further with this one. Currently, in my head, I would see all
image-related things as:
```yaml
registry: ~ # new global docker registry to define (it is rather unlikely to
use more than one in one env)
images: # almost not changed
airflow:
repository: ~
tag: ~ # maybe consolidate with digest
digest: ~ # maybe consolidate with tag
pullPolicy: ~
dagProcessor:
image: # new section in every component airflow (I don't see a use case
for now or future with multiple different e.g. flowers or redis instances)
repository: ~ # possibility to override
tag: ~ # possibility to override
pullPolicy: ~ # possibility to override
```
Something like this would make component separation possible (probably in
line with not yet voted, but some direction in which Airflow is heading with
the whole decoupling work within the components). It would also make it easy
for people who do not want to have separate images to just use global values.
If Airflow in some version fully move to having an image per Docker, we would
just need to deprecate the global one and remove it later in a chart major
version.
`registry` parameter added as a quality-of-life thing (not a matter for this
PR really). Currently, if we are using e.g. celery, we need to specify the same
registry in the repository field in both the airflow, redis and flower `images`
sections, which may not be so obvious for users.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
