Miretpl commented on PR #69261: URL: https://github.com/apache/airflow/pull/69261#issuecomment-4929814953
> On the stock apache/airflow image where the git provider is preinstalled, I still couldn't get a working GitDagBundle configuration through the chart. Happy to open a separate issue with details if it's useful — the point here is only that the migration path isn't yet frictionless from a chart-user perspective. Please do. It is hard to make migration better without accually knowing some edge cases due to different environments. > So users who are on git-sync today will realistically stay on it for a while during the transition, and the duplicate-env behaviour actively blocks Secret-based credential injection for them. The PR is small (one helper, one optional value, one schema entry), additive, and doesn't affect existing users. Would you be OK with me pushing the current state as-is? I'm not looking to expand the scope. If you'd still prefer not to extend git-sync at all, I understand and we can close it. I see the reason for the change, but I lack context regarding the blocked migration to GitDagBundle from the current 1.22 version (the issue may clarify this). Depending on that, we may iterate over this PR and make it reach the 1.x release or close it. We will see. In general, I agree with Jens' comments in https://github.com/apache/airflow/pull/65791. GitSync is planned to be dropped in Helm Chart 2.0, and users who are using GitSync currently are recommended to move to GitDagBundle (we plan to prepare documentation for the migration path in which maybe you would be able to help too after successful migration). General scope for Helm Chart 2.0 - https://github.com/apache/airflow/issues/64037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
