ashb commented on code in PR #67947:
URL: https://github.com/apache/airflow/pull/67947#discussion_r3558545226
##########
airflow-ctl/tests/airflow_ctl/ctl/test_cli_config.py:
##########
@@ -321,6 +321,41 @@ def list(self, is_alive: bool | None = None) ->
JobCollectionResponse | ServerRe
assert is_alive_arg.kwargs["default"] is None
assert is_alive_arg.kwargs["type"] is bool
+ def test_command_factory_body_bool_field_defaults_to_none(self, tmp_path):
+ """Bool fields expanded from a Pydantic body must default to None, not
False.
+
+ Otherwise the dispatcher's ``is not None`` filter passes an unset flag
+ through as ``False``, silently overriding API-side defaults that are
Review Comment:
Pydantic models I think have the concept of what fields have been set or not
on an instance. `body.model_dump(mode="json", exclude_unset=True)` etc.
Do we really need this complexity.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
