goanpeca commented on code in PR #69190: URL: https://github.com/apache/airflow/pull/69190#discussion_r3560475296
########## providers/amazon/tests/system/amazon/aws/example_s3_compatible_object_storage.py: ########## @@ -0,0 +1,91 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Example Dag: input -> transform -> output on an S3-compatible object store via ``ObjectStoragePath``. + +The Amazon provider talks to any S3-compatible object store, so ``ObjectStoragePath("s3://...")`` +reaches the store through the amazon provider once the ``aws`` connection points at its S3 +endpoint. Amazon S3 is the baseline; the same code works against other S3-compatible services +(for example Amazon S3, Backblaze B2, Cloudflare R2, and MinIO). See the recipe "Use an +S3-compatible object store for Airflow remote task logs" for connection and ``[logging]`` setup. + +Set up an ``aws`` connection (default id ``aws_s3``) whose ``extra`` includes the S3 +``endpoint_url`` and ``region_name``. The bucket name comes from ``S3_BUCKET_NAME``. + +Requires the s3fs extra: ``pip install 'apache-airflow-providers-amazon[s3fs]'``. +""" + +from __future__ import annotations + +import os +from datetime import datetime + +from airflow.sdk import ObjectStoragePath, dag, task + +DAG_ID = "example_s3_compatible_object_storage" + +# Connection id and bucket are read from the environment so the example carries no secrets. +S3_CONN_ID = os.environ.get("S3_CONN_ID", "aws_s3") +S3_BUCKET_NAME = os.environ.get("S3_BUCKET_NAME", "my-bucket") + +# ObjectStoragePath resolves the connection lazily, so building it at module scope is safe. +base = ObjectStoragePath(f"s3://{S3_CONN_ID}@{S3_BUCKET_NAME}/airflow-demo") + + +@dag( + schedule=None, + start_date=datetime(2021, 1, 1), + catchup=False, + tags=["example", "s3-compatible", "object-storage"], +) +def example_s3_compatible_object_storage(): + """Write input to the object store, transform it, and write the output back.""" + + @task + def input_to_store() -> str: + """Write a raw input object to the store and return its path.""" + base.mkdir(exist_ok=True) + src = base / "input.txt" + src.write_text("s3\ncompatible\nobject\nstorage\n") + return str(src) Review Comment: Fixed: Replaced the bucket default with a placeholder guard, moved base ObjectStoragePath creation to runtime, and added the trailing slash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
