steveahnahn opened a new pull request, #69736:
URL: https://github.com/apache/airflow/pull/69736

   Split out of #69675 per review feedback there (the change is unrelated to 
that PR's asset-event topic).
   
   `SQLColumnCheckOperator` / `SQLTableCheckOperator` tolerance scaled check 
bounds by `(1 ± tolerance)`, which moves the bound the wrong way when the 
expected value is negative: with `geq_to=-1000` and `tolerance=0.1` the bound 
became `-900`, so a record equal to the threshold (`-1000`) failed the check, 
and `equal_to=-100` produced an empty acceptance band (`[-90, -110]`). The fix 
computes the margin from the magnitude (`abs(expected) * tolerance`), so 
tolerance always widens the bound outward. Bounds for positive expected values 
are unchanged.
   
   Adds parametrized regression tests covering negative thresholds for all five 
comparators, unchanged positive-threshold behavior, and the no-tolerance exact 
path.
   
   related: #69675
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5)
   
   Generated-by: Claude Code (Fable 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to