shivaam commented on PR #69295: URL: https://github.com/apache/airflow/pull/69295#issuecomment-4956298188
One thing I am thinking is that the one command workflow looks good for simple TypeScript projects. My main concern is that airflow-ts-pack always rebuilds the entrypoint using its own esbuild configuration. Projects or teams may use Vite, webpack, or custom esbuild plugins and settings. Could we add a packaging-only mode for an existing .mjs artifact? ``` pnpm vite build pnpm exec airflow-ts-pack --bundle dist/airflow.mjs ``` In this mode, ts-pack would not compile the code again. It would only run the bundle’s metadata introspection and embed the Airflow metadata. We can keep the simple command as the default option and the packaging only mode can be the second option. The only requirement on the user's build output is that the .mjs is a single file node can run directly, with all dependencies bundled inside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
