Copilot commented on code in PR #69815:
URL: https://github.com/apache/airflow/pull/69815#discussion_r3572344890
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1668,10 +1668,9 @@ api:
description: |
Size of the LRU cache for SerializedDAG objects in the API server.
Set to 0 to use an unbounded dict (no eviction, matching pre-3.2
behavior).
- The cache is keyed by Dag version ID, so lookups by Dag ID
- (e.g., viewing a Dag's details) always query the database for the
latest
- version, but the deserialized result is cached for subsequent
- version-specific lookups.
+ The cache is keyed by Dag version ID. Lookups by Dag ID
+ (e.g., viewing a Dag's details) fetch the latest serialized row, but
reuse
+ its cached deserialized DAG when the version ID and hash are unchanged.
Review Comment:
In prose we should use “Dag” (title case) rather than “DAG” unless it’s a
literal code token. Here “cached deserialized DAG” is describing an object, not
the `SerializedDAG` type name.
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -1682,9 +1681,9 @@ api:
After this time, cached DAGs will be re-fetched from the database on
next access.
Set to 0 to disable TTL (cache entries will only be evicted by LRU
policy).
Review Comment:
Use “Dags” in prose instead of “DAGs” (reserved for literal code tokens like
`DAG`/`SerializedDAG`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
