axelray-dev opened a new pull request, #69834: URL: https://github.com/apache/airflow/pull/69834
### Summary Fixes inconsistent validation of custom `remote_base_dir` on `SSHRemoteJobOperator` cleanup (#69813). The operator accepts a custom base directory when constructing job paths, but cleanup validation only allowed the hardcoded defaults (`/tmp/airflow-ssh-jobs` and the Windows temp default). Jobs with a custom base then failed at the end with `ValueError: Invalid job directory ... Expected path under '/tmp/airflow-ssh-jobs'`. ### Changes - Thread an optional expected base into `_validate_job_dir` and the cleanup command builders, defaulting to the existing platform defaults. - Pass the operator-configured base (`RemoteJobPaths.base_dir` / `remote_base_dir`) into cleanup so custom bases validate the same way as defaults. - Keep prefix-plus-separator safety checks so cleanup still rejects paths outside the configured base. ### Verification - Added unit tests for custom-base cleanup success and rejection of paths outside the custom base. - Existing default-path cleanup tests remain. - Targeted provider pytest could not be run in a sparse checkout without the full Airflow workspace; please run provider SSH unit tests in CI. ### Backwards compatibility - Default behavior is unchanged when `remote_base_dir` is unset. - Custom bases that already pass init validation now also pass cleanup validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
