Vamsi-klu commented on PR #69780:
URL: https://github.com/apache/airflow/pull/69780#issuecomment-4966077781
Went through `_deserialize_connection_value` and the new guard reads correct
to me. Good call accepting `uri` as an alternative rather than requiring
`conn_type` outright, since `from_json` passes a bare `uri` to the constructor
which routes through `from_uri` and parses the scheme into the conn_type, so
those blobs still build a usable connection and the `{"conn_type": null, "uri":
...}` test covers exactly that. Raising a `ValueError` up front is a clear
improvement over the misleading connection not found error the PR describes.
Only nit, you `json.loads(value)` in the guard and then `from_json` parses the
same string again, negligible for a small secret blob so I wouldn't bother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
