manipatnam commented on code in PR #64162:
URL: https://github.com/apache/airflow/pull/64162#discussion_r3578903768
##########
airflow-core/src/airflow/timetables/trigger.py:
##########
@@ -87,12 +87,15 @@ def next_dagrun_info(
else:
next_start_time = self._align_to_next(restriction.earliest)
else:
- start_time_candidates =
[self._align_to_prev(coerce_datetime(utcnow()))]
if last_automated_data_interval is not None:
-
start_time_candidates.append(self._get_next(last_automated_data_interval.end))
- elif restriction.earliest is None:
- # Run immediately has no effect if there is restriction on
earliest
- start_time_candidates.append(self._calc_first_run())
+ # _calc_first_run respects run_immediately to decide between
the
+ # most recent past cron point and the next future one.
Review Comment:
run_immediately only exists on the Cron side; DeltaTriggerTimetable's
_calc_first_run() doesn't know anything about it. So mentioning run_immediately
here was misleading for half the classes using this method — good catch.
Regarding the explanation of that statement, I have mentioned it in the next
comment
https://github.com/apache/airflow/pull/64162#discussion_r3578873499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
