kacpermuda opened a new pull request, #69874:
URL: https://github.com/apache/airflow/pull/69874
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
When a task instance is individually set to success or failure via the API,
`on_task_instance_success` / `on_task_instance_failed` is called from the API
server, giving listeners a terminal event to act on. The same does not happen
when an entire Dag Run is force-set to success or failure: running tasks are
bulk-transitioned in the database, but their task-instance listeners are never
fired. Listeners that registered a start event (`on_task_instance_running`) for
those tasks receive no completion event, leaving them — notably OpenLineage —
with a job permanently stuck in RUNNING.
This PR closes the gap:
- `_set_dag_run_terminal_state` now returns `(all_updated_tis, running_tis)`
where `running_tis` is the snapshot of task instances that were in an active
state (RUNNING, DEFERRED, UP_FOR_RESCHEDULE, AWAITING_INPUT) before the bulk
transition, captured without an extra query.
- `set_dag_run_state_to_success` / `set_dag_run_state_to_failed` expose the
same tuple so callers have access to the running subset.
- `patch_dag_run_state` fires `on_task_instance_success` /
`on_task_instance_failed` for those running task instances before the
dag-run-level hook. Each group has its own `try/except` so a listener failure
in one cannot suppress the other.
Tasks that were only QUEUED or SCHEDULED (never started, no start event
fired) are excluded — they transition to SKIPPED and receive no listener call,
consistent with their lifecycle.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (claude-sonnet-4-6)
Generated-by: Claude Code (claude-sonnet-4-6) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
