dhkim1920 commented on PR #69666: URL: https://github.com/apache/airflow/pull/69666#issuecomment-4970339558
Thanks for working on this. I had also started looking into a fix for #69657 and noticed two details that may be worth considering before review: 1. It may be clearer to retain the original external `logical_date` representation in the poke log and show the configured-timezone rendering alongside it, rather than replacing the logged value entirely. This would preserve the canonical value for correlation and debugging while still making the configured local time immediately readable. For example: ```text Poking for DAG 'example_external_dag' on logical_date 2026-07-06T21:00:00+00:00 (default timezone: 2026-07-07T06:00:00+09:00) ... ``` 2. The new test is currently located in `TestExternalTaskSensorV2`, which is skipped when running against Airflow 3. It would be useful to add equivalent coverage to the Airflow 3 test path so that the changed poke log is exercised on the version targeted by this PR. ```python # tests\unit\standard\sensors\test_external_task_sensor.py TestExternalTaskSensorV2: line 135 @pytest.mark.skipif(AIRFLOW_V_3_0_PLUS, reason="Different test for v3.0+") ``` I have a local branch implementing this approach, but I would prefer not to open a near-duplicate PR unless the maintainers would like to evaluate it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
