ferruzzi commented on code in PR #67927:
URL: https://github.com/apache/airflow/pull/67927#discussion_r3583053092
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -552,7 +553,8 @@ def start( # type: ignore[override]
**kwargs,
)
- msg = messages.StartTriggerer()
+ team_name = kwargs.get("team_name")
Review Comment:
This is a bit fragile, no? Shouldn't we add it to the signature as an
explicit parameter? It looks like start() is only called in a handful of
places and they all pass `team_name | None` already unless I'm missing
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
