amoghrajesh opened a new pull request, #69901:
URL: https://github.com/apache/airflow/pull/69901
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Noticed this failure in CI:
```
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:280:
error: No overload variant of "create_or_update" of "FactoriesOperations"
matches argument types "str", "str",
"Factory", "str | None", "dict[str, Any]" [call-overload]
return self.get_conn().factories.create_or_update(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:280:
note: Possible overload variants:
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:280:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, factory: Factory, *, content_type: str = ..., etag: str | None = ...,
match_condition: MatchConditions | None = ..., **kwargs: Any) -> Factory
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:280:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, factory: IO[bytes], *, content_type: str = ..., etag: str | None = ...,
match_condition: MatchConditions | None = ..., **kwargs: Any) -> Factory
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:341:
error: Too many positional arguments for "get" of "LinkedServicesOperations"
[misc]
return self.get_conn().linked_services.get(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:551:
error: Too many positional arguments for "get" of "DataFlowsOperations" [misc]
return self.get_conn().data_flows.get(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:599:
error: No overload variant of "create_or_update" of "DataFlowsOperations"
matches argument types "str", "str",
"str", "DataFlowResource | IO[Any]", "str | None", "dict[str, Any]"
[call-overload]
return self.get_conn().data_flows.create_or_update(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:599:
note: Possible overload variants:
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:599:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, data_flow_name: str, data_flow: DataFlowResource, *, content_type: str =
..., etag: str | None = ..., match_condition: MatchConditions | None = ...,
**kwargs: Any) -> DataFlowResource
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:599:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, data_flow_name: str, data_flow: IO[bytes], *, content_type: str = ...,
etag: str | None = ..., match_condition: MatchConditions | None = ...,
**kwargs: Any) -> DataFlowResource
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:629:
error: No overload variant of "create_or_update" of "DataFlowsOperations"
matches argument types "str", "str",
"str", "DataFlowResource", "str | None", "dict[str, Any]"
[call-overload]
return self.get_conn().data_flows.create_or_update(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:629:
note: Possible overload variants:
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:629:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, data_flow_name: str, data_flow: DataFlowResource, *, content_type: str =
..., etag: str | None = ..., match_condition: MatchConditions | None = ...,
**kwargs: Any) -> DataFlowResource
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:629:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, data_flow_name: str, data_flow: IO[bytes], *, content_type: str = ...,
etag: str | None = ..., match_condition: MatchConditions | None = ...,
**kwargs: Any) -> DataFlowResource
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:925:
error: No overload variant of "create_or_update" of "TriggersOperations"
matches argument types "str", "str",
"str", "TriggerResource", "str | None", "dict[str, Any]" [call-overload]
return self.get_conn().triggers.create_or_update(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:925:
note: Possible overload variants:
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:925:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, trigger_name: str, trigger: TriggerResource, *, content_type: str = ...,
etag: str | None = ..., match_condition: MatchConditions | None = ...,
**kwargs: Any) -> TriggerResource
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/data_factory.py:925:
note: def create_or_update(self, resource_group_name: str, factory_name:
str, trigger_name: str, trigger: IO[bytes], *, content_type: str = ..., etag:
str | None = ..., match_condition: MatchConditions | None = ..., **kwargs: Any)
-> TriggerResource
Found 6 errors in 1 file (checked 4724 source files)
Error 1 returned
```
Caused due to
```diff
116c116
< azure-mgmt-datafactory==9.3.0
---
> azure-mgmt-datafactory==10.0.0
```
The 10.0.0 release regenerated the SDK's operations classes and dropped the
positional `if_match`/`if_none_match` parameters on `create_or_update`/`get` in
favor of a keyword-only `etag` parameter (the standard azure-core
conditional-request pattern, where `etag` maps to `If-Match` on writes and
`If-None-Match` on reads).
Instead of band-aiding it, a better way would be to bump to 10.0+ lower
bound cos current lower bound is ~5years old
<img width="705" height="127" alt="image"
src="https://github.com/user-attachments/assets/c2d33662-d5ae-4bed-869f-0944f2b19bd4";
/>
### User implications / backcompat
None for Airflow users - the hook's public API (`if_match`/`if_none_match`
parameter names on `update_factory`, `get_linked_service`, `get_dataflow`,
`update_dataflow`, `create_dataflow`, `update_trigger`) is unchanged. Only the
internal SDK call shape and the minimum installed SDK version changed.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
