FrankYang0529 opened a new pull request, #69915: URL: https://github.com/apache/airflow/pull/69915
## Why * Followup from https://github.com/apache/airflow/pull/69397#discussion_r3558403532. * The core `airflow dags state` used single field `logical_date_or_run_id` for two different values. The `airflowctl dags state` inherited it. * If the input is a `logical_date`, it spends an extra request trying it as a `run_id` first. That request is bound to 404, and the CLI then uses the list API to retrieve the `dag_run`. An unknown `run_id` has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists. ## How * Add `--logical-date` and make `run_id` an optional positional. Exactly one of the two is required. * `run_id` goes straight to `dag_runs.get` and `--logical-date` goes to `dag_runs.list`. ## Verification * `uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py` <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> * related: #68402 --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes - Claude Code <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
