bugraoz93 commented on code in PR #69879:
URL: https://github.com/apache/airflow/pull/69879#discussion_r3588766962
##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -490,6 +517,8 @@ def _cleanup_table(
extra_filters: list[Any] | None = None,
skip_if_referenced: list[tuple[str, str]] | None = None,
referenced_pk_column: str = "id",
+ fallback_recency_column=None,
Review Comment:
This has been never passed from the caller. I see the enitre logic coupled
with this field and the boolean asked to user. If you check below comment where
it called, you will see we only pass the user input one.
Even this is calculated in inner parts, it should only exists where it is
needed and calculated.
##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -728,6 +764,7 @@ def run_cleanup(
skip_archive=skip_archive,
session=session,
batch_size=batch_size,
+ fallback_cleanup_on_null=fallback_cleanup_on_null,
Review Comment:
Here we are not pssing the other new recency one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
