Tegh25 opened a new pull request, #69943: URL: https://github.com/apache/airflow/pull/69943
Should be able to close #68294 after merge. Follow-up to https://github.com/apache/airflow/pull/68367, https://github.com/apache/airflow/pull/68589, https://github.com/apache/airflow/pull/68593, https://github.com/apache/airflow/pull/68594, https://github.com/apache/airflow/pull/68599, https://github.com/apache/airflow/pull/68108, and https://github.com/apache/airflow/pull/68601. # Primary Changes Added team_name tag to the following: connection_test.reaped connection_test.success connection_test.failed connection_test.hook_duration scheduler.executor_heartbeat_duration triggers.blocked_main_thread Added a team_name field to TestConnection class. This is to share team_name from the scheduler to connection test supervisor without changing the execution API. ## Excerpt from [comment on closing issue](https://github.com/apache/airflow/issues/68294#issuecomment-4725975650): The remaining scope was identified by @ferruzzi and is completed in this PR. ### Remaining work (6) Team-attributable, emit site has a team identity, but no team_name tag yet: - connection_test.reaped (scheduler reaper; ct.team_name is literally in scope and logged one line above the stats.incr, only prior_state is tagged) - connection_test.success (worker connection-test supervisor; per connection-test row) - connection_test.failed (same) - connection_test.hook_duration (same) - scheduler.executor_heartbeat_duration (loops over self.executors; each executor.team_name is available, tagged only by executor class) - triggers.blocked_main_thread (emitted in a team-scoped triggerer's TriggerRunner; team_name lives on the runner/supervisor but is not plumbed to this emit) Two of these are more borderline than the others: scheduler.executor_heartbeat_duration and triggers.blocked_main_thread are component-level (team-scoped executor / team-scoped triggerer). They satisfy the signal list, but if those components are considered "shared," they'd drop to non-team. The four connection_test.* rows are clean Remaining items per the explicit "connection-test row" signal. <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes - Cursor (Auto) Generated-by: Cursor (Auto) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
