pierrejeambrun commented on code in PR #69267:
URL: https://github.com/apache/airflow/pull/69267#discussion_r3596132802
##########
airflow-core/src/airflow/api_fastapi/common/exceptions.py:
##########
@@ -54,6 +54,52 @@ class _DatabaseDialect(Enum):
POSTGRES = "postgres"
+def _build_database_error_response(
Review Comment:
Instead of extracting this into a module level function, can you instead
keep that in `_DatabaseErrorHandler` and make `SQLAlchemyErrorHandler` extend
`_DatabaseErrorHandler` `SQLAlchemyErrorHandler(_DatabaseErrorHandler)`.
This way we keep the interface cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
