github-actions[bot] opened a new pull request, #69974:
URL: https://github.com/apache/airflow/pull/69974

   * UI: Fix partition key display and input handling
   
   Non-partitioned Dag runs showed a dangling "Partition key:" label, an
   empty partition key typed then cleared was sent to the trigger/materialize
   APIs and rejected with 400, the trigger form exposed the field even for
   non-partitioned Dags, the manual asset-event partition key used a
   JsonEditor for a plain string, and the runs table hid the partition_key
   column even when its filter was shown for a partitioned Dag. Also unify
   the partition key label so cron/runtime-partitioned runs no longer say
   "Mapped Partition key".
   
   * fixup! UI: Fix partition key display and input handling
   
   * fixup! fixup! UI: Fix partition key display and input handling
   
   * UI: Extract shared partition key normalization util
   
   The trigger form and manual/materialize asset-event flows each
   duplicated the same undefined/empty-string-to-null check before
   sending partition_key to the API, making the normalization easy to
   get subtly wrong in one call site while fixing it in another.
   
   * UI: Simplify partition key visibility check on asset event page
   
   Collapse the redundant undefined/null comparison into a single
   loose-equality null check, matching the reviewer's simplification
   of the earlier partition key display fix.
   
   * UI: Remove partition-key column auto-visibility from the runs table
   
   The runs table hid the partition_key column by default and revealed it
   only for partitioned Dags by fetching Dag details and forcing a table
   remount once the answer arrived. That remount-on-load approach was
   fragile, and the show/hide behaviour is better solved by a reusable
   mechanism (one that could also drive e.g. hiding map_index for
   non-mapped tasks), so it is dropped here to be reworked separately.
   (cherry picked from commit b767477397dc94b30bb51bd2001196b9392c492e)
   
   Co-authored-by: Wei Lee <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to