Vamsi-klu commented on PR #67931: URL: https://github.com/apache/airflow/pull/67931#issuecomment-5000005088
The new layout is much easier to scan, but the bundled `SmtpNotifier` template is not limited to failure callbacks. Notifiers can also be attached to callbacks such as `on_success_callback` and `on_retry_callback`; whenever `ti` is present, this template currently renders the red `Airflow Task Failed` heading regardless of the actual task state. Could you make that heading state-aware or neutral and add a regression test with a non-failure state? It would also be useful to assert the new Dag, task, state, and log-link fields directly, including that the log URL is the link target. The current default-template test sets `TEST_TASK_STATE = None` and only checks the subject and try count, so it does not protect most of the new behavior. The two failing jobs are setup-only failures: both exhausted their stash-artifact download retries during `Prepare breeze & CI image`, before their test steps ran. A rebase and clean rerun are still needed, but those failures are not product-test failures. The before/after screenshots are already present, so no additional screenshot request is needed. --- Drafted-by: Codex (GPT-5); reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
