shahar1 commented on code in PR #68930: URL: https://github.com/apache/airflow/pull/68930#discussion_r3603904855
########## providers/google/tests/system/google/resources_cleanup/airflow_google_provider_resource_cleanup/commands/cmd_list_asset_types.py: ########## @@ -0,0 +1,122 @@ +# Review Comment: Needs test coverage ########## providers/google/tests/system/google/resources_cleanup/airflow_google_provider_resource_cleanup/helpers.py: ########## @@ -0,0 +1,216 @@ +# Review Comment: Needs test coverage ########## providers/google/tests/system/google/resources_cleanup/.airflowignore: ########## @@ -0,0 +1 @@ +* Review Comment: At least `.airflowignore` should be safe to remove ########## providers/google/tests/system/google/resources_cleanup/pyproject.toml: ########## @@ -0,0 +1,74 @@ +# Review Comment: Merging the tool into the system tests looks indeed a better call. In that case, maybe instead of maintaining a separate `pyproject.toml`, could we just reuse the existing Google's `pyproject.toml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
