uranusjr commented on code in PR #70073: URL: https://github.com/apache/airflow/pull/70073#discussion_r3608342054
########## providers/http/docs/triggers.rst: ########## @@ -21,10 +21,11 @@ HTTP Event Trigger .. _howto/trigger:HttpEventTrigger: -The ``HttpEventTrigger`` is an event-based trigger that monitors whether responses -from an API meet the conditions set by the user in the ``response_check`` callable. +The ``HttpEventTrigger`` is an event-based trigger that monitors whether responses from an API meet the conditions set +by the user in the ``response_check`` callable. If the condition is met, then the Trigger "fires". Otherwise, it waits Review Comment: ```suggestion by the user in the ``response_check_path`` callable. If the condition is met, then the trigger "fires". Otherwise, it waits ``` I think this has always been wrong? Let’s fix it while we’re changing the text anyway. ########## providers/http/docs/triggers.rst: ########## @@ -110,32 +121,31 @@ Parameters ---------- ``http_conn_id`` - http connection id that has the base API url i.e https://www.google.com/ and optional authentication credentials. - Default headers can also be specified in the Extra field in json format. + HTTP Connection ID that has the base API url i.e https://www.google.com/ and optional authentication credentials. Default headers can also be specified in the ``extra`` field in JSON format. Review Comment: ```suggestion HTTP Connection ID that has the base API URL, e.g. ``https://www.google.com/``, and optional authentication credentials. Default headers can also be specified in the ``extra`` field in JSON format. ``` ########## providers/http/docs/triggers.rst: ########## @@ -64,18 +65,27 @@ Here's an example of using the HttpEventTrigger in an AssetWatcher to monitor th async def check_github_api_response(response): + """Determine if a new version of Airflow has been released.""" + # Convert Variable.get to be asynchronous to be used on the Triggerer + get_variable_async = sync_to_async(Variable.get) + + # Retrieve the previous and current release ID's (one from Variables, one from response) Review Comment: ```suggestion # Retrieve the previous and current release IDs (one from Variables, one from response) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
