Andrushika commented on PR #69937: URL: https://github.com/apache/airflow/pull/69937#issuecomment-5011818029
Oh, I see...... I have no problem putting this on hold or even closing it. The reason I opened this PR is that I thought the behavior across lang SDKs should be aligned. I saw #69400 in ts-sdk, so I thought it would be good to introduce the same validation in java-sdk. > If we really want to checks this, I would want to do this in the dag processor, and only in Python For the current mixed-lang Dag, I agree that the Python stub is the source of truth, so validation in each lang SDK may not be needed. > the validation should be useful for the upcoming native Dag so no harm to introduce it. If we need validation in lang SDKs for native Dag in the future, the discrepancy TP mentioned would still exist. In that case, maybe we can keep the valid and invalid Dag/task IDs as shared test cases and let all the lang SDKs use them, instead of defining the expected behavior separately in each SDK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
