justinpakzad commented on code in PR #69768:
URL: https://github.com/apache/airflow/pull/69768#discussion_r3609161652
##########
airflow-core/tests/unit/cli/commands/test_team_command.py:
##########
@@ -79,6 +79,25 @@ def test_team_create_success(self, stdout_capture):
assert "Team 'test-team' created successfully" in output
assert str(team.name) in output
+ def test_team_create_creates_default_pool(self, stdout_capture):
+ """Test that creating a team also creates its default pool."""
+ with conf_vars(
+ {
+ ("core", "multi_team"): "True",
+ ("multi_team", "default_team_pool_slots"): "128",
Review Comment:
One more thing I caught on the second pass. I don't think
`default_team_pool_slots` is even a config option. The actual command fetches
the slots via `conf.getint("core", "default_pool_task_slot_count")`. The
`assert pool.slots == 128` happens to pass since the default is already 128,
but if you changed the value in the conf_vars to say 64 (or any other value)
and asserted, it would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
