potiuk commented on PR #65840: URL: https://github.com/apache/airflow/pull/65840#issuecomment-5017259343
I really think that this is far too much to solve the issue. It does not solve the actual issue described - being able to quickly iterate n the theme changes while working on docs. Looking at the current implementation, I think a better approach would be to handle the case differently: 1) checkout "airflow-site" repo locally somewhgere 2) Run breeze with `--local-theme <path>` to mount-bind the theme from checked-out airflow-site 3) Iterate and run doc build in breeze while haivng the theme mounted from "airflow-site" - including "dev" building the assets on the flight. That would be far less intrusive - and would be an "easy" dev-env for docs - and it would solve the case where we want to be able to work on theme and see the result of it in versioned docs - while also (in airflow-site) build the docs for landing page and the website with the same theme. Then the flow would be: 1) iterate locally on the change 2)commit / merge the airflow-site changes and release them while site is built 3) commit the local changes once the new them is published by site build I think that seem like closes to what the issue describes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
