nailo2c commented on code in PR #67286:
URL: https://github.com/apache/airflow/pull/67286#discussion_r3611827963


##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -214,16 +216,13 @@ def ti_run(
             previous_state=previous_state,
         )
 
-        # TODO: Pass a RFC 9457 compliant error message in "detail" field
-        # https://datatracker.ietf.org/doc/html/rfc9457
-        # to provide more information about the error
-        # FastAPI will automatically convert this to a JSON response
-        # This might be added in FastAPI in 
https://github.com/fastapi/fastapi/issues/10370

Review Comment:
   I think we should keep this comment (maybe in an updated form), since we put 
the RFC 9457 related members in detail, but it's still not the standard 
structure of RFC 9457.
   
   In the FastAPI roadmap (fastapi/fastapi#10370), the task Errors based on RFC 
9457 is still open. We should keep it to remind us that the current way doesn't 
fully fit RFC 9457.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to