steveahnahn commented on code in PR #69586: URL: https://github.com/apache/airflow/pull/69586#discussion_r3611908921
########## providers/google/src/airflow/providers/google/cloud/operators/dataflow.py: ########## Review Comment: The trigger builds the hook with `drain_pipeline`, so draining works in the deferrable path too. Dropped the deferrable clause in [56c4223](https://github.com/apache/airflow/pull/69586/commits/56c42232d2ad5f48f1ebf0d2f8f409c8e00c7acd) ########## providers/google/src/airflow/providers/google/cloud/operators/dataflow.py: ########## @@ -793,6 +794,7 @@ def execute(self, context: Context) -> dict[str, Any]: cancel_timeout=self.cancel_timeout, expected_terminal_state=self.expected_terminal_state, impersonation_chain=self.impersonation_chain, + drain_pipeline=self.drain_pipeline, ), Review Comment: Same, fixed in the latest push. `DataflowStartYamlJobOperator` takes `cancel_on_kill` and passes it to `DataflowStartYamlJobTrigger`. ########## providers/google/src/airflow/providers/google/cloud/operators/dataflow.py: ########## @@ -633,6 +633,7 @@ def set_current_job(current_job): poll_sleep=self.poll_sleep, impersonation_chain=self.impersonation_chain, cancel_timeout=self.cancel_timeout, + drain_pipeline=self.drain_pipeline, Review Comment: Fixed in the latest push: all three operators now take `cancel_on_kill` and pass it into the trigger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
