viiccwen commented on code in PR #69926:
URL: https://github.com/apache/airflow/pull/69926#discussion_r3613235593
##########
go-sdk/pkg/worker/runner.go:
##########
@@ -273,12 +273,9 @@ func (w *worker) ExecuteTaskWorkload(ctx context.Context,
workload api.ExecuteTa
slog.Int("status_code", resp.StatusCode()),
slog.Group(
"request",
- "url",
- resp.Request.URL,
- "method",
- resp.Request.Method,
- "headers",
- resp.Request.Header,
+ slog.String("path",
resp.Request.RawRequest.URL.Path),
Review Comment:
At that time, I think full url may contain sensitive query parameters or
embedded credentials. The test intentionally puts the workload token in the
query string to cover that case. Logging the path, method, and correlation ID
preserves the useful request context without exposing credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
