Andrushika commented on code in PR #69965:
URL: https://github.com/apache/airflow/pull/69965#discussion_r3615283850
##########
go-sdk/bundle/bundlev1/registry.go:
##########
@@ -20,13 +20,34 @@ package bundlev1
import (
"fmt"
"reflect"
+ "regexp"
"runtime"
"strings"
"sync"
+ "unicode/utf8"
"github.com/apache/airflow/go-sdk/pkg/worker"
)
+const maxKeyLength = 250
+
+var keyRegex = regexp.MustCompile(`^[\p{L}\p{N}_.-]+$`)
Review Comment:
Thanks. I may be wrong, but the linked code checks run_id, while this PR
checks Dag and task IDs. Should the validation of run_id and Dags, task IDs
align? If so, I will open a follow-up PR to fix this in task SDK.
Since the PR is on hold, should I wait for the coordinator's design before
making this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
