suyua9 commented on PR #70067: URL: https://github.com/apache/airflow/pull/70067#issuecomment-5031313467
Addressed the review feedback and refreshed the branch onto the current `main`: - read the environment value into a local `domain` variable before handling the unset/empty fallback; - retained the existing unset, empty, and custom-value regression coverage; - changed the PR title to the repository-required non-Conventional-Commits form. Validation run: - `git diff --check` - `ruff format --check providers/google/src/airflow/providers/google/common/hooks/base_google.py` - `ruff check providers/google/src/airflow/providers/google/common/hooks/base_google.py` - `python3 -m compileall -q providers/google/src/airflow/providers/google/common/hooks/base_google.py` The targeted pytest command could not run locally because this checkout requires `uv >=0.11.8` while the installed version is `0.10.8`; CI will cover the existing targeted regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
