korex-f commented on PR #66633: URL: https://github.com/apache/airflow/pull/66633#issuecomment-5032508137
> > > Can the provider related changes be split into a dedicated PR? > > > > > > Done! All provider and shared/logging changes were already reverted in the latest push per @jason810496's guidance. This PR now touches only task-sdk/src/airflow/sdk/execution_time/supervisor.py and task-sdk/src/airflow/sdk/log.py. The provider-side fix is being handled separately in #68779. > > You may not have pushed that, there are still provider changes in the current diff: > > ``` > diff --git a/providers/amazon/src/airflow/providers/amazon/aws/log/cloudwatch_task_handler.py > - def upload(self, path: os.PathLike | str, ti: RuntimeTI): > + def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None: > > diff --git a/providers/elasticsearch/src/airflow/providers/elasticsearch/log/es_task_handler.py > - def upload(self, path: os.PathLike | str, ti: RuntimeTI): > + def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None: > + if ti is None: > + return > > diff --git a/providers/opensearch/src/airflow/providers/opensearch/log/os_task_handler.py > - def upload(self, path: os.PathLike | str, ti: RuntimeTI): > + def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None: > + if ti is None: > + return > ``` > > Edit to add: the whitespace change in supervisor.py that you said was done is also not there. Sorry for the confusion, the revert was there but spread across multiple commits, making it look like provider changes were still present in the per-commit view. The net diff against upstream/main now only touches task-sdk/src/airflow/sdk/execution_time/supervisor.py and task-sdk/src/airflow/sdk/log.py. No provider files are modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
