amoghrajesh opened a new pull request, #70178:
URL: https://github.com/apache/airflow/pull/70178
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
### Why?
Airflow only surfaced spark-submit's exit code when the process failed,
discarding the JVM's actual stdout/stderr (missing jar, bad main class,
Kerberos errors, etc.). Humans and Retry policies evaluating these exceptions
had nothing but an exit code to reason from.
Some cases I encountered are when Spark's `SparkSubmitHook.submit()` raises
`AirflowException` on three
failure paths:
- a nonzero spark-submit exit code,
- a Kubernetes exit-code mismatch, and
- a standalone-cluster submit that produced no driver id.
In all three cases the exception message contained only the masked command
line and an exit code -- never the spark-submit process's own stdout/stderr,
even though that output already streams through `_process_spark_submit_log()`
line by line and often contains the real cause (missing jar, bad main class,
Kerberos failure, etc.).
This makes root-causing failures harder for humans, and gives
automated/LLM-based retry policies nothing to work with beyond an exit code cos
they can't distinguish a transient submit infra hiccup from a permanent
misconfiguration.
### What
This PR adds a small rolling buffer of the last 20 lines of spark-submit's
own output (`_last_submit_log_lines`, populated in
`_process_spark_submit_log`) and appends it, masked the same way the command
line already is, to all three submit-failure exceptions via a new
`_format_submit_log_tail()` helper. Example:
```shell
"Cannot execute: spark-submit --master spark://spark-master:7077
--deploy-mode cluster "
"/opt/spark/apps/does-not-exist.jar. Error code is: 1.\n"
"Last spark-submit output:\n"
"WARNING: Using incubator modules: jdk.incubator.vector\n"
"26/07/21 07:03:03 WARN NativeCodeLoader: Unable to load
native-hadoop library for your "
"platform... using builtin-java classes where applicable\n"
'Exception in thread "main" org.apache.spark.SparkException:
Failed to get main class in '
"JAR with error 'File file:/opt/spark/apps/does-not-exist.jar
does not exist'. Please "
"specify one with --class.\n"
"\tat
org.apache.spark.deploy.SparkSubmit.error(SparkSubmit.scala:1065)\n"
"\tat
org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment(SparkSubmit.scala:547)\n"
"\tat
org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:95)"
```
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
