dabla opened a new pull request, #70223:
URL: https://github.com/apache/airflow/pull/70223
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: [#62922](https://github.com/apache/airflow/pull/62922)
-->
Add a `POST /xcoms/{dag_id}/{run_id}/{task_id}/keys` execution API endpoint
that
accepts a list of XCom keys and returns all matching values in a single
database
query. Use it in `XComIterable` to reduce iteration from N round-trips to
one.
### Motivation
`XComIterable` (introduced in [AIP-104 Task
Iteration](https://github.com/apache/airflow/pull/62922)) stores per-index
results
under distinct keys (`return_value_0`, `return_value_1`, …) with the same
`map_index`. The existing `GET …/slice` endpoint cannot be reused because it
ranges over `map_index` for a single key — the inverse structure. Iterating
or
slicing a 1000-item result previously issued 1000 separate `XCom.get_one`
calls.
### Changes
- **New endpoint** `POST /xcoms/{dag_id}/{run_id}/{task_id}/keys` — accepts
`{"keys": [...]}`, returns values in request-key order (`null` for missing
keys), filtered by `map_index` query param (default `-1`)
- **`has_xcom_access`** simplified: reads the optional `key` from
`request.path_params` instead of requiring a `{key}` path segment, so a
separate router/dependency is no longer needed
- **`XComKeysRequest`** Pydantic model added to execution API data models
- **`GetXComByKeys`** comms message, `XComOperations.get_by_keys` client
method,
`handle_get_xcom_by_keys` supervisor handler, and processor dispatch wiring
- **`XComIterable.__iter__`** and **`__getitem__` slice** now use
`GetXComByKeys`
— one round-trip for full iteration, deserialization kept lazy via
generator
expression in `__iter__`
- Tests for the new endpoint (`TestGetXComByKeys`) and for `XComIterable`
(`TestXComIterable`)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ x ] Yes (please specify the tool below)
Claude Sonnet 4.6 (GitHub Copilot CLI)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
