FrankYang0529 commented on code in PR #69578:
URL: https://github.com/apache/airflow/pull/69578#discussion_r3634922626
##########
scripts/ci/prek/check_metrics_synced_with_the_registry.py:
##########
@@ -251,22 +289,23 @@ def scan_file_for_metrics(file_path: Path) ->
list[MetricCall]:
if name_node is None:
continue
- metric_name = extract_metric_name_from_ast_node(name_node)
- if metric_name is None:
+ metric_names = extract_metric_names_from_ast_node(name_node)
+ if not metric_names:
Review Comment:
Updated it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]