Lee-W commented on code in PR #70291:
URL: https://github.com/apache/airflow/pull/70291#discussion_r3637388196
##########
dev/registry/tests/test_extract_parameters.py:
##########
@@ -225,6 +225,24 @@ def execute(self, context):
return None
+class ManuallyDurableOperator:
+ """Implements durable execution directly (e.g. via task_state_store),
without
+ ResumableJobMixin -- mirrors KubernetesPodOperator/AgentOperator."""
+
+ __supports_durable_execution = True
Review Comment:
since we're accessing this value through the registry script, i start to
think maybe it's ok to make it public? or `_...`?
##########
dev/registry/tests/test_extract_parameters.py:
##########
@@ -225,6 +225,24 @@ def execute(self, context):
return None
+class ManuallyDurableOperator:
+ """Implements durable execution directly (e.g. via task_state_store),
without
+ ResumableJobMixin -- mirrors KubernetesPodOperator/AgentOperator."""
+
+ __supports_durable_execution = True
Review Comment:
After a second thought, do we really need `__`? Are we worrying whether the
user will change it? Or is there any reason we need to use `__`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
