shahar1 commented on code in PR #70256:
URL: https://github.com/apache/airflow/pull/70256#discussion_r3640879460


##########
providers/common/sql/docs/changelog.rst:
##########
@@ -25,6 +25,18 @@
 Changelog
 ---------
 
+2.0.3
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Make psycopg (v3) the default synchronous Postgres driver (#69526)``

Review Comment:
   Good catch — reclassified to `Misc` in d5264b6.
   
   You're right that there's no principled reason for the different call. The 
slice adds a psycopg (v3) / psycopg2 fallback in `get_sqlalchemy_engine()` for 
bare `postgresql://` URLs, which reads like a bug fix — but the break it guards 
against (psycopg2 not being installed) only exists because **this same wave** 
turns psycopg2 into an optional extra of the postgres provider. In the released 
state psycopg2 was a hard dependency, so nothing was actually broken; the slice 
adapts to an in-wave change rather than fixing released behaviour, which makes 
it `Misc` — the same call already made in amazon, google, and celery for this 
PR. Postgres keeps its `Breaking changes` entry, since that's where the default 
driver actually changes.
   
   ---
   Drafted-by: Claude Code (Opus 4.8) (no human review before posting)



##########
providers/pgvector/docs/changelog.rst:
##########
@@ -20,6 +20,24 @@
 Changelog
 ---------
 
+1.7.3
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Make psycopg (v3) the default synchronous Postgres driver (#69526)``

Review Comment:
   Same reasoning as the common.sql thread — reclassified to `Misc` in d5264b6. 
The pgvector slice adds a `USE_PSYCOPG3` branch that adapts to the postgres 
provider's new in-wave default driver rather than fixing released behaviour, so 
it lines up with the `Misc` classification the same PR already has in amazon, 
google, and celery.
   
   ---
   Drafted-by: Claude Code (Opus 4.8) (no human review before posting)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to