1fanwang opened a new pull request, #70335:
URL: https://github.com/apache/airflow/pull/70335

   `kueue_version` is a template field, so it is rendered after `__init__` 
runs. The constructor baked it into `self._kueue_yaml_url`, so a templated 
`kueue_version` (e.g. `"{{ var.value.kueue_ver }}"`) produced a download URL 
containing the un-rendered Jinja expression, and `execute()` fetched the 
manifest from that bogus URL. Compute the URL in a property so it uses the 
rendered version.
   
   related: #70296
   
   cc @shahar1
   
   <details><summary>Testing Done</summary>
   
   New `test_kueue_yaml_url_uses_rendered_version` renders a templated 
`kueue_version` and asserts `_kueue_yaml_url` resolves to the real release URL. 
It fails on the pre-fix source (URL still contains `{{ params.v }}`) and passes 
after. `test_kueue.py`: 11 passed. `validate_operators_init.py` on the operator 
exits 0.
   
   </details>
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: GitHub Copilot CLI following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to