xBis7 commented on code in PR #69633:
URL: https://github.com/apache/airflow/pull/69633#discussion_r3644819125
##########
shared/observability/tests/observability/test_traces.py:
##########
@@ -43,6 +43,23 @@ def _carrier_is_sampled(carrier: dict[str, str]) -> bool:
return trace.get_current_span(ctx).get_span_context().trace_flags.sampled
+def _carrier_span_context(carrier: dict[str, str]):
+ ctx = TraceContextTextMapPropagator().extract(carrier)
Review Comment:
This sounds like a valid comment.
> So that distros and configurations can leverage their own?
@tailg8nj Can you explain the need for this? Is there a scenario where the
user would need to use a custom propagator in general? For example, not just
here but throughout the project, in all other places where we propagate the
context. Attach and detach something to every context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
