uranusjr commented on code in PR #69933:
URL: https://github.com/apache/airflow/pull/69933#discussion_r3649699560
##########
airflow-core/src/airflow/serialization/definitions/taskgroup.py:
##########
@@ -248,9 +255,24 @@ def topological_sort(self) -> list[DAGNode]:
return self._sweep_projection(nodes, projected)
def _project_child_deps(
- self, child_idx: int, child: DAGNode, id_to_idx: dict[str, int]
+ self,
+ child_idx: int,
+ child: DAGNode,
+ id_to_idx: dict[str, int],
+ group_dict: dict[str | None, SerializedTaskGroup],
) -> tuple[int, ...]:
- upstream_ids = child.upstream_task_ids
+ if isinstance(child, SerializedTaskGroup):
Review Comment:
Why is this needed? This class _is_ SerializedTaskGroup, and this should
always return True? When does the `else` block kick in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
