yuseok89 opened a new pull request, #70470:
URL: https://github.com/apache/airflow/pull/70470
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Follow-up to #69875, the run-state filter UX refactor that reviewers asked
to split into its own PR.
The Dags list had two separate run-state filters ("Last run" and "Any run")
side by side. This merges them into a single Run state control with a scope
selector, and adds an optional time window so the run-state filters can target
a recent period instead of an unbounded run history.
related: #67094
### What changed
- UI: The two run-state selects become one `Run state` select plus a scope:
`Latest run` / `Last 24 hours` / `Last 7 days` / `Last 30 days` / `Any time`.
Picking a state defaults the scope to Latest run, so today's behavior is
unchanged. The scope maps onto the existing `last_dag_run_state` /
`dag_run_state` params; a time window adds `dag_run_state_within` (hours).
- Backend: `_AnyDagRunStateFilter` gains an optional
`dag_run_state_within_hours` bound, applied inside the existing correlated
`EXISTS`.
### ⚠️ Performance validation still pending
Marking this [WIP] because the new time bound isn't perf-validated yet. The
`run_after` bound isn't covered by the existing `dag_id_state` index, so before
this merges I want to measure the windowed filter on a large `dag_run` table
(millions of rows) and see whether an index change is needed. I'll post the
numbers here and lift the WIP.
### Demo
Screen recording to follow.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Opus 4.8
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
