dsuhinin commented on code in PR #68393:
URL: https://github.com/apache/airflow/pull/68393#discussion_r3659007692
##########
shared/observability/src/airflow_shared/observability/metrics/otel_logger.py:
##########
@@ -435,70 +437,130 @@ def atexit_register_metrics_flush():
atexit.register(flush_otel_metrics)
-def get_otel_logger(
+def _get_backcompat_config(
Review Comment:
thank you! good catch — restored both warnings in _get_backcompat_config(),
with the wording from the removed get_otel_data_exporter: the "both provided,
using the environment variables" one when the deprecated otel_host/otel_port
pair is set alongside OTEL_EXPORTER_OTLP_[METRICS_]ENDPOINT, and the
deprecation warning on the bridging path. Added a parametrized test covering
both paths, plus the no-deprecated-conf case staying silent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
