shahar1 opened a new pull request, #70637:
URL: https://github.com/apache/airflow/pull/70637

   `main` currently fails `Compile / format / lint UI` for every PR that 
triggers a full static-check run.
   
   #68919 made `DeadlineAlertResponse.interval` nullable (`float | None`) for 
dynamic intervals — a `VariableInterval` whose value is only resolved at 
scheduler evaluation time — but the generated TypeScript client was not 
regenerated. The stale client still declared `interval: number`, which masked a 
real type error: once the client is regenerated, `tsc` fails at five call sites 
that pass the value straight to `dayjs.duration(...)`.
   
   This regenerates the client and makes those call sites tolerate a null 
interval.
   
   A dynamic interval has no duration to display, so the "Must complete within 
X of Y" line is omitted rather than rendered with a placeholder — that avoids 
adding a translation key across every locale, and it matches the guard 
`DeadlineRow.tsx` already had (which was unreachable while the type said 
`number`). The shared `humanizeSeconds` helper keeps the null handling in one 
place next to the existing null-tolerant `renderDuration`.
   
   Reproduce on `main` with no changes: `prek run ts-compile-lint-ui 
--all-files`.
   
   related: #68919
   
   > [!NOTE]
   > `v3-3-test` will need the same fix. #70625 backports the same datamodel 
change and touches only backend files, so merging it as-is reproduces this 
breakage there. Folding these changes into that PR before it merges avoids 
landing the breakage and cherry-picking a follow-up.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.5)
   
   Generated-by: Claude Code (Opus 4.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to