Lee-W commented on code in PR #70499:
URL: https://github.com/apache/airflow/pull/70499#discussion_r3674452847
##########
airflow-core/src/airflow/provider.yaml.schema.json:
##########
@@ -397,6 +397,30 @@
]
}
},
+ "retry-policies": {
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "integration-name": {
+ "type": "string",
+ "description": "Integration name. It must have a
matching item in the 'integration' section of any provider."
Review Comment:
Added `retry-policies` to the resource-type lists in
`check_invalid_integration` and
`check_duplicates_in_integrations_names_of_hooks_sensors_operators`, plus a new
`check_retry_policy_modules_exist_and_belong_to_package` that runs the
`python-modules` existence check.
I did not add `retry-policies` to the list in
`check_correctness_of_list_of_sensors_operators_hook_trigger_modules`, so
`glob`-based completeness is deliberately not asserted for this section.
##########
dev/registry/registry_tools/types.py:
##########
@@ -121,6 +128,7 @@
("bundle", "airflow.dag_processing.bundles.base.BaseDagBundle"),
("operator", "airflow.sdk.bases.operator.BaseOperator"),
("toolset", "pydantic_ai.toolsets.abstract.AbstractToolset"),
+ ("retry_policy", "airflow.sdk.definitions.retry_policy.RetryPolicy"),
Review Comment:
Added `(RetryPolicy, "retry-policies")` to `base_class_resource_map` and
`"retry-policies"` to the tuple that builds `registered_modules`. Both were
needed — with only the first, the class is found but never counted as
registered.
Now if we remove the declaration from `common/ai/provider.yaml`,
`LLMRetryPolicy` will be reported as unregistered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
