potiuk commented on PR #70670: URL: https://github.com/apache/airflow/pull/70670#issuecomment-5120491709
Pushed [4fa3fcf](https://github.com/apache/airflow/commit/4fa3fcf21a8168d86cae6410c1a94b13490aaac5), which clears the CI failures from the model regeneration. The generated models no longer carry a spurious `= None` for fields the spec marks `required` but nullable, so the remaining call sites have to name them: - `test_rotate_fernet_key_command.py` — `schema_=` → `schema=`. A third instance of the alias bug already fixed twice in this PR: the value was being dropped, and the old implicit default hid it. - `providers/amazon/.../test_base_aws.py` — names the six now-required `ConnectionResult` fields. - `providers/openlineage/.../test_listener.py` — see below. - `ts-sdk/src/generated/supervisor.ts` — regenerated; it derives from the same supervisor schema snapshot this PR already regenerates. cc @mmobuchowski @kacpermuda for the OpenLineage change — 26 tests in `TestOpenLineageListenerAirflow3` were failing on `SdkDagRun` validation. Two points worth a look: - `data_interval_start` / `data_interval_end` are passed as `None`, not datetimes. The runtime-TI tests assert `nominal_start_time=None` / `nominal_end_time=None`, so a real datetime would trade one failure for another. `None` reproduces exactly what the old implicit default produced. - The three new keys (`data_interval_start`, `data_interval_end`, `partition_key`) go through the same `if field in SdkDagRun.model_fields` guard the existing `state` key already used, so the file keeps working against the older SDKs the provider supports (`apache-airflow>=2.11.0`). No production code changed here — test fixtures plus one generated file. The `Helm tests / Release Helm` failure is unrelated to this PR: `chart/Chart.yaml` pulls `postgresql` from the retired `charts.bitnami.com/bitnami` index, so it fails on any PR that runs helm tests. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
