Lee-W commented on code in PR #70498:
URL: https://github.com/apache/airflow/pull/70498#discussion_r3680439129
##########
registry/src/js/provider-filters.js:
##########
@@ -33,16 +33,27 @@
let currentSearch = '';
let debounceTimer;
+ // Kept in sync by hand with normalize() in
src/_data/providerKeywordMatch.js:
Review Comment:
I think it's ok to use comment here. I don't expect this will change often
##########
registry/src/providers.njk:
##########
@@ -63,12 +63,19 @@ mainClass: providers-page
{% set lc = provider.lifecycle or "production" %}
{% set lcDisplay = "incubation" if lc == "incubation" else ("deprecated"
if lc == "deprecated" else "stable") %}
{% set cats = providerCategoryMap[provider.id] or [] %}
+ {% set integrations = [] %}
+ {% for cat in provider.categories or [] %}
+ {% if cat.name %}
+ {% set integrations = (integrations.push(cat.name | lower),
integrations) %}
Review Comment:
Dropped the loop — `data-integrations` is the inline `selectattr('name') |
join(',', 'name') | lower` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
