RoyLee1224 commented on code in PR #70120:
URL: https://github.com/apache/airflow/pull/70120#discussion_r3680798826


##########
dev/skill-evals/eval.py:
##########
@@ -207,20 +220,55 @@ def remove_worktree(wt_dir: Path) -> None:
     run(["git", "-C", str(REPO_ROOT), "worktree", "remove", "--force", 
str(wt_dir)])
 
 
-def build_provider(label: str, working_dir: Path, model: str, skill_name: str 
| None = None) -> dict:
+def build_provider(label: str, working_dir: Path, model: str | None, 
skill_name: str | None = None) -> dict:
     config: dict = {
-        "model": model,
         "apiKeyRequired": False,
         "setting_sources": ["project"],
         "append_allowed_tools": ["Read", "Grep", "Glob"],
         "working_dir": str(working_dir),
         "output_format": OUTPUT_FORMAT,
     }
+    if model:
+        config["model"] = model
     if skill_name:
         config["skills"] = [skill_name]
     return {"id": "anthropic:claude-agent-sdk", "label": label, "config": 
config}
 
 
+def build_codex_provider(

Review Comment:
   Nice catch, thanks! The Codex provider now raises `project_doc_max_bytes` so 
the complete `AGENTS.md` is included in the evaluation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to